Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-use big.Int in DecomposePQ #14

Merged
merged 1 commit into from
Dec 13, 2020
Merged

Re-use big.Int in DecomposePQ #14

merged 1 commit into from
Dec 13, 2020

Conversation

tdakkota
Copy link
Member

@tdakkota tdakkota commented Dec 13, 2020 •
edited
Loading

Old:

goos: windows
goarch: amd64
pkg: github.com/gotd/td/internal/crypto
BenchmarkDecomposePQ
BenchmarkDecomposePQ-4   	      16	 707597638 ns/op	33065308 B/op	 3485209 allocs/op
PASS

New:

goos: windows
goarch: amd64
pkg: github.com/gotd/td/internal/crypto
BenchmarkDecomposePQ
BenchmarkDecomposePQ-4           26   541487342 ns/op    863167 B/op    107167 allocs/op
PASS

benchcmp

benchmark                  old ns/op     new ns/op     delta
BenchmarkDecomposePQ-4     707597638     541487342     -23.48%

benchmark                  old allocs     new allocs     delta
BenchmarkDecomposePQ-4     3485209        107167         -96.93%

benchmark                  old bytes     new bytes     delta
BenchmarkDecomposePQ-4     33065308      863167        -97.39%

@coveralls
Copy link

coveralls commented Dec 13, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 419039109

  • 25 of 25 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 32.623%
Totals Coverage Status
Change from base Build 418983756: 0.2%
Covered Lines: 1653
Relevant Lines: 5067
💛 - Coveralls

@ernado ernado merged commit 9a9ff79 into gotd:main Dec 13, 2020
@tdakkota tdakkota deleted the fix/optimize-decompose-pq branch May 29, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tdakkota @coveralls @ernado